Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rip2 0.9.0 (new formula) #196052

Merged
merged 2 commits into from
Nov 1, 2024
Merged

rip2 0.9.0 (new formula) #196052

merged 2 commits into from
Nov 1, 2024

Conversation

bkaplowitz
Copy link
Contributor

provides maintained version of rip under new rip2 name with new features.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

It fails no fork but otherwise passes. As mentioned the original rip repo has not been maintained since 2020 and was previously listed under rm-improved or rip names.

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Oct 30, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Formula/r/rip2.rb Outdated Show resolved Hide resolved
Formula/r/rip2.rb Outdated Show resolved Hide resolved
Formula/r/rip2.rb Outdated Show resolved Hide resolved
Formula/r/rip2.rb Outdated Show resolved Hide resolved
Formula/r/rip2.rb Outdated Show resolved Hide resolved
Formula/r/rip2.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 30, 2024
@bkaplowitz
Copy link
Contributor Author

thanks for fast reply. Resolved the issues indicated above.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 30, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 30, 2024
@bkaplowitz bkaplowitz force-pushed the rip2-formula branch 2 times, most recently from 7c70ec3 to e5b558a Compare October 30, 2024 15:44
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 30, 2024
@bkaplowitz
Copy link
Contributor Author

Okay, changes above should be fixed. It is failing on CI for audit it seems.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 31, 2024
Formula/r/rip2.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

chenrui333 commented Oct 31, 2024

since rip (aka rm-improved) is not maintainable, we can do something like rip@1 and rip kind of thing (which we did with gdrive #154959), this way, we dont need to include conflicts resolution.

@chenrui333
Copy link
Member

never mind, it is not quite applicable in here:

  • rip in cargo registry is called rm-improved, while rip2 is called rip2 (no naming consistency)
  • the last rip release is 0.13.1, while rip2 is 0.9.0 (actually version downgrade)

@chenrui333 chenrui333 added the in progress Stale bot should stay away label Oct 31, 2024
@bkaplowitz
Copy link
Contributor Author

bkaplowitz commented Nov 1, 2024

since rip (aka rm-improved) is not maintainable, we can do something like rip@1 and rip kind of thing (which we did with gdrive #154959), this way, we dont need to include conflicts resolution.

Yes, it is not obvious that there is a good way to handle it other than a new formula unless we just call it rip. That's up to the maintainer, though. For now, we could list it as rip2, and if they decide they want to change the name later, they can.

@carlocab carlocab added the CI-skip-new-formulae Pass --skip-new to brew test-bot. label Nov 1, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 1, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine when CI is green, but the CI failure needs fixing:

  Error: Failure while executing; `\{\"SHELL\"=\>\"bash\"\} /home/linuxbrew/.linuxbrew/Cellar/rip2/0.9.0/bin/rip completion bash` exited with 1. Here's the output:
  Exception: Cannot remove completion: no such file or directory

https://github.com/Homebrew/homebrew-core/actions/runs/11632416879/job/32395750693?pr=196052#step:4:118

Please also squash your commits together when done.

@carlocab carlocab added maintainer feedback Additional maintainers' opinions may be needed audit failure CI fails while auditing the software labels Nov 1, 2024
@bkaplowitz bkaplowitz force-pushed the rip2-formula branch 3 times, most recently from ed54de6 to cd7f7d4 Compare November 1, 2024 18:43
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 1, 2024
Formula/r/rip2.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 1, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 1, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added this pull request to the merge queue Nov 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 1, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 1, 2024
Merged via the queue into Homebrew:master with commit 2e4271b Nov 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit failure CI fails while auditing the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-new-formulae Pass --skip-new to brew test-bot. in progress Stale bot should stay away maintainer feedback Additional maintainers' opinions may be needed new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants